APS-1677 AP occupancy view #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmeredith
force-pushed
the
feature/APS-1677_ap_occupancy_view
branch
from
5dc8ed4 to
5e0bcce
Compare
bobmeredith
commented
Dec 20, 2024
bobmeredith
commented
Dec 20, 2024
| <ul class="calendar__month govuk-list"> | ||
| {% for day in month.days %} | ||
| <li class="calendar__day calendar__day--{{ day.name.slice(0,3) | lower }}{% if day.status !== 'available' %} {{ 'govuk-tag--yellow' if day.status in ['availableForCriteria','full'] else 'govuk-tag--red' }}{% endif %}"> | ||
| <a class="calendar__link" href="{% if day.link %}{{ day.link }}{% else %}#{% endif %}"> |
There was a problem hiding this comment.
So this assumes that all calendars are rendered with a link property in their day structures. I could put this in the lower level day templates, but that would mean more of the day rendering, including the date name, would be duplicated.
aliuk2012
approved these changes
Dec 23, 2024
bobmeredith
commented
Dec 23, 2024
| @@ -21,5 +21,13 @@ export const premisesActions = (user: UserDetails, premises: Premises) => { | |||
| }) | |||
| } | |||
|
|
|||
| if (user.permissions.includes('cas1_premises_view') && premises.supportsSpaceBookings) { | |||
There was a problem hiding this comment.
Changed to an explicit test for permission - but this permission is already given to users in prod.
The supportsSpaceBookings flag however is not set on any premises ATM, and will be set on rollout in February.
bobmeredith
force-pushed
the
feature/APS-1677_ap_occupancy_view
branch
from
df4809f to
7c0a7ee
Compare
aliuk2012
reviewed
Dec 23, 2024
bobmeredith
force-pushed
the
feature/APS-1677_ap_occupancy_view
branch
from
db3c4fd to
d27d30f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://dsdmoj.atlassian.net/browse/APS-1677
Changes in this PR
Adds the occupancy view (calendar) page with a link from the premises view action menu.
Screenshots of UI changes